Skip to content

Commit

Permalink
edencommon: patch to increase test discovery timeout
Browse files Browse the repository at this point in the history
For some reason, this build is incredibly flaky on `x86_64-darwin`,
possibly because of the recent `staging-next` merge, failing with a
test discovery timeout error both on Hydra and locally. The default
discovery timeout is apparently 5 seconds, so let’s try giving it
5 times as long and see if that helps.
  • Loading branch information
emilazy committed Sep 5, 2024
1 parent 2495ff4 commit 912531f
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkgs/development/libraries/edencommon/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ stdenv.mkDerivation rec {
sha256 = "sha256-1z4QicS98juv4bUEbHBkCjVJHEhnoJyLYp4zMHmDbMg=";
};

patches = lib.optionals (stdenv.isDarwin && stdenv.isx86_64) [
# Test discovery timeout is bizarrely flaky on `x86_64-darwin`
./increase-test-discovery-timeout.patch
];

nativeBuildInputs = [ cmake ];

cmakeFlags = lib.optionals stdenv.isDarwin [
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
diff --git a/eden/common/os/test/CMakeLists.txt b/eden/common/os/test/CMakeLists.txt
index a9f71443f8..be1423c455 100644
--- a/eden/common/os/test/CMakeLists.txt
+++ b/eden/common/os/test/CMakeLists.txt
@@ -18,4 +18,4 @@
${LIBGMOCK_LIBRARIES}
)

-gtest_discover_tests(os_test)
+gtest_discover_tests(os_test DISCOVERY_TIMEOUT 25)
diff --git a/eden/common/utils/test/CMakeLists.txt b/eden/common/utils/test/CMakeLists.txt
index 0cac73e569..ff08ecccb8 100644
--- a/eden/common/utils/test/CMakeLists.txt
+++ b/eden/common/utils/test/CMakeLists.txt
@@ -34,4 +34,4 @@
${LIBGMOCK_LIBRARIES}
)

-gtest_discover_tests(utils_test)
+gtest_discover_tests(utils_test DISCOVERY_TIMEOUT 25)

0 comments on commit 912531f

Please sign in to comment.