Fix for bad cwd default and fix for entries option not getting passed #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beefy is pretty amazing, and I've been using the CLI for a little while now, but today I decided to check out using the API interface, and sort of fell down a rabbit hole discovering bugs. This pull request fixes two of them and leaves the third for someone else. :)
The first bug is that the default for the
cwdoption was getting set to., which was causing thefixupEntriesfunction to replace the.in sayindex.jswith a/.The second bug was that the
entriesoption was not actually getting passed to thesetupBundlerfunction. That would result in the entry points getting served as static files instead of getting bundled.The third bug that this PR does not fix is that the docs indicate that you can pass an object for the
entriesoption. I attempted to add support for this, however doing so causes the "concurrent conns do not trigger a warning" integration test to hang. I spent a long while trying to figure out why to no avail.Thanks for writing beefy! Please let me know if there are any changes you'd like me to make. (Or feel free to reject…this is my first GitHub PR so I've likely messed something up!)