fix: default in attr ensures default values

* no need for explicit assigns https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#attr/3-options
chrisgreg · May 5, 2024 · b7e5304 · b7e5304
1 parent b2ec37f
commit b7e5304
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/lib/bloom/components/marquee.ex b/lib/bloom/components/marquee.ex
@@ -42,13 +42,6 @@ defmodule Bloom.Components.Marquee do
   slot(:inner_block, required: true)
 
   def marquee(assigns) do
-    assigns =
-      assigns
-      |> assign(:repeat, assigns[:repeat] || 4)
-      |> assign(:vertical, assigns[:vertical] || false)
-      |> assign(:pause_on_hover, assigns[:pause_on_hover] || false)
-      |> assign(:reverse, assigns[:reverse] || false)
-
     ~H"""
     <div
       :if={@repeat > 0}

diff --git a/priv/templates/marquee.ex b/priv/templates/marquee.ex
@@ -42,13 +42,6 @@ defmodule <%= @module_name %>Web.Components.Marquee do
   slot(:inner_block, required: true)
 
   def marquee(assigns) do
-    assigns =
-      assigns
-      |> assign(:repeat, assigns[:repeat] || 4)
-      |> assign(:vertical, assigns[:vertical] || false)
-      |> assign(:pause_on_hover, assigns[:pause_on_hover] || false)
-      |> assign(:reverse, assigns[:reverse] || false)
-
     ~H"""
     <div
       :if={@repeat > 0}