-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added base for a bloom_button
component with a variant attribute
#2
Added base for a bloom_button
component with a variant attribute
#2
Conversation
bloom_button
component with a variant attribute
I have some free time next week, is something missing here? :) can I be of any assistance? Additionally I had a look on frankenui: https://www.franken-ui.dev what do you think of transporting some of them to bloom? seems like a great base for many things :) |
@webspaceadam - Apologies for the long delay! I've been extremely busy with life recently but back to getting Bloom up to scratch. I'd love the contribution from some of Franken UI components if you're still up for it! |
Great! Currently we started working with the petal.build components and i am still missing some things, so when i transform a franken-ui component i will add it here and create a PR :) |
👋🏼 Hey!
First of all: Great project.
I just started to fiddle around in the elixir world a few weeks ago.
as i came to the phoenix world (as mentioned on twitter a total noob still) i saw the potential but missed the capabilities of the react ecosystem. so adding value to those kind of endeavours seems to be the right move 👨🏼💻
What i implemented
with the core components coming with phoenix we already have great stuff to start implementing simple UIs in elixir, but i always missed the ability to have an outlined variant of the button.
so thats what i added. the
bloom_button
can of course become a way bigger and more complex component, but an additional variant seems like a good start to me.i hope i did everything right.
Open Question
how does versioning work here in the elixir world? i know changesets for js projects and i would add one here. i see a changelog -> should i extend it manually, will you do it?
kind regards and hopefully this is of any help. any feedback appreciated :)