javascript interop #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds capability for Javascript hooks to be added to components, and installed alongside Elixir component templates.
Implementation details
Javascript hooks are authored in the
assets/js/folder, and are moved alongside the.extemplates whenmix bloom.generate_templatesis run. Then onmix bloom.install Xthe JS file is added toassets/js/vendor/hooks/X.jsJust like the Elixir components, it is then up to the consumer of the package to wire up the hook ready for use.
Note
I opted for a basic
npm initto get the types in place for more complex hooks, and Javascript tooling to be added later.If you have strong preference for either
yarnorpnpm(orbun) then I'm happy to switch that outTesting
See a new component with hook implemented in #5