Change SettingsValidator method to static

The Validate method in SettingsValidator class got changed from an instance method to a static method. This was done to avoid creating unnecessary instances of SettingsValidator when validating settings in GenerateCommand.cs. The related call in GenerateCommand has been modified accordingly.
christianhelle · Oct 27, 2023 · 67ffe12 · 67ffe12
1 parent 6f70d56
commit 67ffe12
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Refitter/GenerateCommand.cs b/src/Refitter/GenerateCommand.cs
@@ -19,7 +19,7 @@ public override ValidationResult Validate(CommandContext context, Settings setti
  if (!settings.NoLogging)
  Analytics.Configure();
 
- return new SettingsValidator().Validate(settings);
+ return SettingsValidator.Validate(settings);
  }
 
  public override async Task<int> ExecuteAsync(CommandContext context, Settings settings)

diff --git a/src/Refitter/SettingsValidator.cs b/src/Refitter/SettingsValidator.cs
@@ -4,9 +4,9 @@
 
 namespace Refitter;
 
-public class SettingsValidator
+public static class SettingsValidator
 {
- public ValidationResult Validate(Settings settings)
+ public static ValidationResult Validate(Settings settings)
  {
  if (BothSettingsFilesAreEmpty(settings) || BothSettingsFilesArePresent(settings))
  {