Remove namespace settings from codeGeneratorSettings
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace setting in `codeGeneratorSettings` and related documentation was removed. This setting is a duplicated and was never respected, it was just causing confusion and was deemed unnecessary. The `namespace` property is already defined in `RefitGeneratorSettings` and from the CLI argument `--namespace`
Updated the READMEs and code comments in the refitter project to properly reflect the usage of the 'operationNameTemplate' setting. The previous description was unclear on its function when using multiple interfaces setting as 'ByEndpoint'. The changes provide better, clearer guidance for users on how to use the setting in different scenarios.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 98.64% 98.64% -0.01%
==========================================
Files 52 52
Lines 1841 1840 -1
==========================================
- Hits 1816 1815 -1
Misses 9 9
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace setting in
codeGeneratorSettingsand related documentation was removed. This setting is a duplicated and was never respected, it was just causing confusion and was deemed unnecessary. Thenamespaceproperty is already defined inRefitGeneratorSettingsand from the CLI argument--namespaceThis resolves the recent issue mentioned in #186 reported by @alrz