Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Full garbage collection #3194

Open
wants to merge 4 commits into
base: 11-23-implement_update_and_delete
Choose a base branch
from
Open

[ENH] Full garbage collection #3194

wants to merge 4 commits into from

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 25, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Full garbage collection in spann

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This was referenced Nov 25, 2024
Merged
Merged
Merged
Open
Open
Open
Open
@sanketkedia sanketkedia changed the title basic garbage collection [ENH] Full garbage collection Nov 25, 2024
@sanketkedia sanketkedia mentioned this pull request Nov 25, 2024
Open
1 task
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Nov 25, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia marked this pull request as ready for review November 25, 2024 23:33
@sanketkedia sanketkedia force-pushed the 11-23-implement_update_and_delete branch from a69dfa8 to bf69dba Compare November 29, 2024 06:50
This was referenced Nov 29, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB Awaiting requested review from HammadB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sanketkedia