Added URL encoding to the query parameters on build query string method.

chroma-x · Jul 12, 2016 · 2c4ea3d · 2c4ea3d
1 parent b45dd09
commit 2c4ea3d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/QueryParameter.php b/src/QueryParameter.php
@@ -63,6 +63,14 @@ public function getValue()
 		return $this->value;
 	}
 
+	/**
+	 * @return string
+	 */
+	public function getEscapedValue()
+	{
+		return urlencode((string)$this->value);
+	}
+
 	/**
 	 * @param mixed $value
 	 * @return $this

diff --git a/src/QueryParameterInterface.php b/src/QueryParameterInterface.php
@@ -34,6 +34,11 @@ public function setKey($key);
 	 */
 	public function getValue();
 
+	/**
+	 * @return string
+	 */
+	public function getEscapedValue();
+
 	/**
 	 * @param mixed $value
 	 * @return $this

diff --git a/src/Url.php b/src/Url.php
@@ -134,7 +134,7 @@ public function buildQueryString()
 		}
 		$queryParameters = array();
 		foreach ($this->getQueryParameters() as $queryParameter) {
-			$queryParameters[] = $queryParameter->getKey() . '=' . $queryParameter->getValue();
+			$queryParameters[] = $queryParameter->getKey() . '=' . $queryParameter->getEscapedValue();
 		}
 		return implode(self::URL_QUERY_SEPARATOR, $queryParameters);
 	}