Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.10] Add "use HeadlessChromium\Dom\Selector\XPathSelector;" #573

Merged
merged 1 commit into from
Mar 17, 2024
Merged

[1.10] Add "use HeadlessChromium\Dom\Selector\XPathSelector;" #573

merged 1 commit into from
Mar 17, 2024

Conversation

divinity76
Copy link
Contributor

makes it easier to follow sample code, i had to look it up in the source code myself.

@divinity76
add "use HeadlessChromium\Dom\Selector\XPathSelector;"
d7fd838 
makes it easier to follow sample code, i had to look it up in the source code myself.
@enricodias
Copy link
Member

I think this one can go straight to 1.11 if we don't add anything else to 1.10. No need to push an extra version just for a doc change.

@divinity76 divinity76 changed the base branch from 1.10 to 1.11 December 31, 2023 09:42
@divinity76
Copy link
Contributor Author

¯\_(ツ)_/¯ changed target branch.

@GrahamCampbell GrahamCampbell changed the title add "use HeadlessChromium\Dom\Selector\XPathSelector;" [1.11] Add "use HeadlessChromium\Dom\Selector\XPathSelector;" Jan 1, 2024
@GrahamCampbell GrahamCampbell changed the base branch from 1.11 to 1.10 March 17, 2024 22:46
@GrahamCampbell GrahamCampbell merged commit 269ae8c into chrome-php:1.10 Mar 17, 2024
14 checks passed
@GrahamCampbell GrahamCampbell changed the title [1.11] Add "use HeadlessChromium\Dom\Selector\XPathSelector;" [1.10] Add "use HeadlessChromium\Dom\Selector\XPathSelector;" Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divinity76 @enricodias @GrahamCampbell