Restore the placeholder when search is focused

chromium · Dec 23, 2023 · 3abc3a7 · 3abc3a7
1 parent dc57ecc
commit 3abc3a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/subdoc/lib/gen/generate_head.cc b/subdoc/lib/gen/generate_head.cc
@@ -120,9 +120,16 @@ void generate_head(HtmlWriter& html, std::string_view title,
               e.preventDefault();
             }
           };
+          var searchPlaceholder;
           document.querySelector(".search-input").onfocus = (e) => {
+            searchPlaceholder = e.target.placeholder;
+            e.target.placeholder = "Type your search here.";
             navigateToSearch(e.target.value);
           };
+          document.querySelector(".search-input").onblur = (e) => {
+            e.target.placeholder = searchPlaceholder;
+            searchPlaceholder = null;
+          };
         });
 
         // Show or hide any DOM element.

diff --git a/subdoc/lib/gen/generate_search.cc b/subdoc/lib/gen/generate_search.cc
@@ -33,9 +33,6 @@ void generate_search_header(HtmlWriter::OpenMain& main) noexcept {
       search_input.add_autocomplete("off");
       search_input.add_spellcheck("false");
       search_input.add_placeholder("Click or press 'S' to search...");
-      search_input.add_onblur(
-          "this.placeholder = 'Click or press \\'S\\' to search...'");
-      search_input.add_onfocus("this.placeholder = 'Type your search here.'");
     }
   }