forked from jesseduffield/lazygit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test demonstrating problem with ForEachLineInFile
The function drops the last line if it doesn't end with a line feed.
- Loading branch information
1 parent
ae610dc
commit 72cf3ef
Showing
1 changed file
with
63 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
package utils | ||
|
||
import ( | ||
"strings" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func Test_forEachLineInStream(t *testing.T) { | ||
scenarios := []struct { | ||
name string | ||
input string | ||
expectedLines []string | ||
}{ | ||
{ | ||
name: "empty input", | ||
input: "", | ||
expectedLines: []string{}, | ||
}, | ||
{ | ||
name: "single line", | ||
input: "abc\n", | ||
expectedLines: []string{"abc\n"}, | ||
}, | ||
{ | ||
name: "single line without line feed", | ||
input: "abc", | ||
/* EXPECTED: | ||
expectedLines: []string{"abc"}, | ||
ACTUAL: */ | ||
expectedLines: []string{}, | ||
}, | ||
{ | ||
name: "multiple lines", | ||
input: "abc\ndef\n", | ||
expectedLines: []string{"abc\n", "def\n"}, | ||
}, | ||
{ | ||
name: "multiple lines including empty lines", | ||
input: "abc\n\ndef\n", | ||
expectedLines: []string{"abc\n", "\n", "def\n"}, | ||
}, | ||
{ | ||
name: "multiple lines without linefeed at end of file", | ||
input: "abc\ndef\nghi", | ||
/* EXPECTED: | ||
expectedLines: []string{"abc\n", "def\n", "ghi"}, | ||
ACTUAL: */ | ||
expectedLines: []string{"abc\n", "def\n"}, | ||
}, | ||
} | ||
|
||
for _, s := range scenarios { | ||
t.Run(s.name, func(t *testing.T) { | ||
lines := []string{} | ||
forEachLineInStream(strings.NewReader(s.input), func(line string, i int) { | ||
lines = append(lines, line) | ||
}) | ||
assert.EqualValues(t, s.expectedLines, lines) | ||
}) | ||
} | ||
} |