Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter and bugfix for service integration #443

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Alter and bugfix for service integration #443

merged 6 commits into from
Jan 10, 2024

Conversation

fivegrant
Copy link
Collaborator

No description provided.

@fivegrant fivegrant changed the title Add ensemble dir to setup.cfg Alter and bugfix for service integration Dec 22, 2023
@SamWitty
Copy link
Contributor

SamWitty commented Jan 2, 2024

Thanks for this PR @fivegrant . It looks like the tests are failing because the changes to the output of calibrate haven't been propagated through all of the tests. For example, see: https://github.com/ciemss/pyciemss/blob/44055b5c906d768410f989d3de89672e111a27b8/tests/test_interfaces.py#L213C4-L213C4

In addition, could you address the linting error by calling make format from the root directory to automatically format the files and tests, and then run make lint to check (and debug) types? Thanks!

@SamWitty SamWitty added awaiting response PR reviewer awaiting response from submitter integration Tasks for integration with TA4 labels Jan 2, 2024
@fivegrant fivegrant changed the title Alter and bugfix for service integration WIP - Alter and bugfix for service integration Jan 2, 2024
@fivegrant fivegrant added the WIP PR submitter still making changes, not ready for review label Jan 2, 2024
@fivegrant
Copy link
Collaborator Author

Good points @SamWitty . I'll make sure to lint and fix tests. I'm going to keep this PR around until the service refactor is ready just in case I need to make any more changes.

@fivegrant fivegrant removed the awaiting response PR reviewer awaiting response from submitter label Jan 2, 2024
@fivegrant fivegrant changed the title WIP - Alter and bugfix for service integration Alter and bugfix for service integration Jan 4, 2024
@fivegrant fivegrant removed the WIP PR submitter still making changes, not ready for review label Jan 8, 2024
@fivegrant
Copy link
Collaborator Author

@SamWitty I went ahead and removed the WIP label. I'll just reopen new PRs as needed. This current PR should be good to go.

SamWitty
SamWitty approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamWitty SamWitty merged commit d03ef2b into ciemss:main Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWitty SamWitty SamWitty approved these changes

Assignees

@fivegrant fivegrant

Labels
integration Tasks for integration with TA4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fivegrant @SamWitty