Add progress hook (and example usage in test) for calibrate
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWitty
added
awaiting review
fivegrant
approved these changes
Jan 2, 2024
fivegrant
added a commit
to fivegrant/pyciemss
that referenced
this pull request
Jan 3, 2024
* Add `ensemble` dir to `setup.cfg` * Align return type of `calibrate` * Change "parameters" -> "inferred_parameters" * added pyciemss logging wrapper to calibrate (ciemss#444) * Add progress hook (and example usage in test) for `calibrate` (ciemss#445) * added progress hook for calibrate * added test with simple logging * lint * Fix formatting, linting, etc --------- Co-authored-by: Sam Witty <samawitty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR addresses a comment in #444 by @fivegrant about how the progress hook for
calibratewent missing after the refactoring PR in #431 . Here, we implement a progress hook by calling a user-provided function of the iteration idiand theloss, which the user can make stateful. In the tests we show an example of a progress hook that logs the iteration ids and losses, and stores them as an attribute.