Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew Cask for Cinny #316

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Homebrew Cask for Cinny #316

wants to merge 5 commits into from

Conversation

Neved4
Copy link

@Neved4 Neved4 commented Jul 25, 2024

Description

Adds a Cask formula to install Cinny using the Homebrew package manager.

Finally fixes #62

After this PR, Cinny can be installed with:

brew tap cinnyapp/cinny-desktop https://github.com/cinnyapp/cinny-desktop
brew install cinny

The Cask formula could be moved into its own separate homebrew-tap repo under the Cinny project. See #62 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Jul 25, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Neved4
Copy link
Author

Neved4 commented Jul 25, 2024

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Jul 25, 2024
Comment on lines +2 to +3
version "4.0.3"
sha256 "1aff22fa0b20b82daf5ab578ed4ed658311226bc5417081a0f4af5d32a84c446"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the cask be automatically updated or we will have to do it manually? Also will it use the built-in auto update or something else?
If not can we setup something to update the cask file automatically?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are great questions:

  • Updating is now manual, it's a good idea to automate it later
  • Uses the built-in auto update as per cinny.rb#L15
  • We can certainly setup something, like the Homebrew bump formula GitHub Action,
    setting ${{secrets.TOKEN}} and the rest in a .yml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please setup auto-update along with this addition as we want to automate as much release workflow we can.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Added the GitHub Action, let me know if anything else is needed.

@Neved4 Neved4 requested a review from kfiven July 31, 2024 11:52
@Neved4
Copy link
Author

Neved4 commented Jul 31, 2024

Note that the public_repo and workflow scopes are required in the custom access token ${{secrets.TOKEN}}

Also, moving the Casks/ into a separate homebrew-tap repo within Cinny's org will make installs simpler:

brew install cinnyapp/tap/cinny

@Neved4
Copy link
Author

Neved4 commented Sep 12, 2024

@kfiven had this running in my own private tap for a while now

So far delivering the last few upgrades with no issues: Neved4/tap/cinny_v4.2.0

Let me know if further help is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release macOS arm build of cinny-desktop + hombrew cask
2 participants