-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to restore Cinny's window size and position #327
Open
Neved4
wants to merge
6
commits into
cinnyapp:main
Choose a base branch
from
Neved4:window-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neved4
force-pushed
the
window-state
branch
3 times, most recently
from
August 2, 2024 23:43
a6ce2c8
to
12858c8
Compare
@kfiven Hey Krishan, any news on this? Sending best wishes |
kfiven
requested changes
Sep 12, 2024
Neved4
force-pushed
the
window-state
branch
from
September 12, 2024 17:18
330008e
to
5612eec
Compare
Neved4
force-pushed
the
window-state
branch
from
September 12, 2024 17:19
5612eec
to
59de259
Compare
Hey, could you please also resolve conflicts? |
@kfiven Done! |
Closed
Neved4
changed the title
Add ability to restore Cinny's window position
Add ability to restore Cinny's window size and position
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables Cinny on macOS to restore its window state from past sessions, using Tauri's
window-state
.Fixes #326 #125
Note that
v2
isn’t used to prevent conflicts withgtk-3
. We might switch to v2 later, but for now we’re sticking withv1
to avoid breaking issues.Type of change
Checklist: