Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to restore Cinny's window size and position #327

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Neved4
Copy link

@Neved4 Neved4 commented Aug 2, 2024

Description

Enables Cinny on macOS to restore its window state from past sessions, using Tauri's window-state.

Fixes #326 #125

Note that v2 isn’t used to prevent conflicts with gtk-3. We might switch to v2 later, but for now we’re sticking with v1 to avoid breaking issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Neved4 Neved4 force-pushed the window-state branch 3 times, most recently from a6ce2c8 to 12858c8 Compare August 2, 2024 23:43
@Neved4 Neved4 marked this pull request as draft August 7, 2024 10:24
@Neved4 Neved4 marked this pull request as ready for review August 7, 2024 10:24
@Neved4
Copy link
Author

Neved4 commented Sep 12, 2024

@kfiven Hey Krishan, any news on this? Sending best wishes

src-tauri/Cargo.toml Outdated Show resolved Hide resolved
@kfiven
Copy link
Collaborator

kfiven commented Sep 13, 2024

Hey, could you please also resolve conflicts?

@Neved4
Copy link
Author

Neved4 commented Sep 14, 2024

@kfiven Done!

@kfiven kfiven mentioned this pull request Sep 22, 2024
@Neved4 Neved4 requested a review from kfiven October 16, 2024 13:01
@Neved4 Neved4 changed the title Add ability to restore Cinny's window position Add ability to restore Cinny's window size and position Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cinny does not remember window position on macOS
2 participants