Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --nokepub parameter to kcc-c2e.py #748

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

soda3x
Copy link
Contributor

@soda3x soda3x commented Oct 2, 2024

This adds a --nokepub parameter to kcc-c2e.py. My rationale for adding this is as follows:

  • I use KCC in a docker container which is a simple script that watches a comic directory for new comics and then calls KCC to convert to EPUB so i can read on my Kobo reader.
  • I use Komga to host my comics
  • Komga has recently introduced kepubify to automatically convert epub --> kepub
  • As this tool, before this pull request, outputs .kepub.epub, Komga / kepubify gets a bit confused and tries to do .kepub.epub.kepub.epub or something similarly foolish and just freaks out that it's not a valid extension (fair enough)

I think this tool is great and I'd love to have the flexibility of generating just epubs with this change :)

soda3x added 2 commits October 2, 2024 21:43
By setting this to true, '.epub' format will be output rather than
'.kepub.epub'
@axu2

This comment was marked as resolved.

@soda3x

This comment was marked as resolved.

@axu2

This comment was marked as resolved.

@soda3x

This comment was marked as resolved.

@axu2
Copy link
Collaborator

axu2 commented Dec 13, 2024

Got to be honest, I've never tested the kepub parts of the code or know much about kepub as a kindle user, but I feel like just changing the extension is sus. Wouldn't it be more appropriate to change kepubify to ignore things that end in kepub.epub?

EDIT: OK, looking at KCC code, it seems KCC really does just make an EPUB and rename it to kepub, so I guess this PR is fine from a technical perspective so I don't mind merging. Still seems a little strange though, which do you think is better? Change KCC or change kepubify?

@axu2 axu2 merged commit e0b1848 into ciromattia:master Dec 13, 2024
@soda3x
Copy link
Contributor Author

soda3x commented Dec 14, 2024

@axu2 yeah it's a bit weird, it seems to be a convention thing. This is definitely the easier of the two options! Thanks for merging :) Appreciate this software

@axu2
Copy link
Collaborator

axu2 commented Dec 14, 2024

@soda3x thanks for the contribution! If you have time take a look at our backlog of Kobo issues.

@axu2
Copy link
Collaborator

axu2 commented Dec 15, 2024

@soda3x
Copy link
Contributor Author

soda3x commented Dec 15, 2024

@soda3x do the kepubs made by kepubify support bookmarks or annotation?

I can have a look once I'm home :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants