Show more lines on failure

cirruslabs · Aug 17, 2020 · f99be0d · f99be0d
1 parent f792393
commit f99be0d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/renderers/config/interactive_config.go b/renderers/config/interactive_config.go
@@ -12,6 +12,7 @@ type InteractiveRendererConfig struct {
 	ProgressIndicatorCycleDuration time.Duration
 	SuccessStatus                  string
 	FailureStatus                  string
+	DescriptionLinesWhenFailed     int
 }
 
 func NewDefaultRenderingConfig() *InteractiveRendererConfig {
@@ -24,6 +25,7 @@ func NewDefaultRenderingConfig() *InteractiveRendererConfig {
 		ProgressIndicatorCycleDuration: time.Second,
 		SuccessStatus:                  "✅",
 		FailureStatus:                  "❌",
+		DescriptionLinesWhenFailed:     100,
 	}
 }
 

diff --git a/renderers/interactive.go b/renderers/interactive.go
@@ -54,6 +54,7 @@ func (r *InteractiveRenderer) RenderScopeFinished(entry *echelon.LogScopeFinishe
 		}
 		n.CompleteWithColor(r.config.SuccessStatus, r.config.Colors.SuccessColor)
 	} else {
+		n.SetVisibleDescriptionLines(r.config.DescriptionLinesWhenFailed)
 		n.CompleteWithColor(r.config.FailureStatus, r.config.Colors.FailureColor)
 	}
 }

diff --git a/renderers/internal/node/echelone_node.go b/renderers/internal/node/echelone_node.go
@@ -98,7 +98,7 @@ func (node *EchelonNode) Render() []string {
 	tail := node.renderChildren()
 	node.lock.RLock()
 	defer node.lock.RUnlock()
-	if len(node.description) > node.visibleDescriptionLines {
+	if len(node.description) > node.visibleDescriptionLines && node.visibleDescriptionLines >= 0 {
 		tail = append(tail, "...")
 		tail = append(tail, node.description[(len(node.description)-node.visibleDescriptionLines):]...)
 	} else {