Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage pull request for: skeleton #52

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Lineage pull request for: skeleton #52

merged 11 commits into from
Sep 23, 2024

Commits on May 21, 2024

  1. Pin ansible-core when running the ansible-lint linter

    New versions of ansible-core (2.16.7 and 2.17.0) have been released
    that do not suffer from the bug discussed in ansible/ansible#82702.
    This bug broke any symlinked files in vars, tasks, etc. for any
    Ansible role installed via ansible-galaxy.
    
    All versions later than ansible-core 2.16.7 and 2.17.0 should function
    as expected.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed May 21, 2024
    Configuration menu
    Copy the full SHA
    07e2b60 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary line

    The line is not only unnecessary, it was commented out to boot!
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c74e5db View commit details
    Browse the repository at this point in the history
  3. Explain why ansible may need to be added as a dependency for ansible-…

    …lint
    
    On its own ansible-lint does not pull in ansible, only ansible-core.
    Therefore, if an Ansible module lives in ansible instead of
    ansible-core, the linter will complain that the module is unknown.  In
    these cases it is necessary to add the ansible package itself as an
    additional dependency, with the same pinning as is done in
    requirements-test.txt of cisagov/skeleton-ansible-role.
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2e53e0d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f51fe62 View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8e55b8e View commit details
    Browse the repository at this point in the history
  3. Correct commented-out ansible pin

    The pin now agrees with what is in cisagov/skeleton-ansible-role.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c617bb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de92c3c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #182 from cisagov/improvement/pin-packages-for-ans…

    …ible-lint
    
    Pin packages for `ansible-lint`
    mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7ddea47 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0e7d723 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge pull request #218 from cisagov/lineage/skeleton

    Lineage pull request for: skeleton
    jsf9k authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aa8b6dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4757110 View commit details
    Browse the repository at this point in the history