ISSUE #2259: Update authorizing official to senior official #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealslimhsiehdy
requested review from
rachidatecs,
abroddrick,
dave-kennedy-ecs,
Katherine-Osos,
erinysong,
zandercymatics and
a team
erinysong
approved these changes
Jun 20, 2024
| @@ -2,6 +2,6 @@ Complete your request as quickly as possible by taking these actions.{.checklist | |||
|
|
|||
| - **Eligibility**: [Make sure your organization is eligible to have a .gov domain](../../domains/eligibility/). | |||
| - **Domain name**: [Choose an available .gov domain that complies with our requirements](../../domains/choosing/). | |||
| - **Authorizing official**: [Find out who your authorizing official is](../../domains/eligibility/#you-must-have-approval-from-an-authorizing-official-within-your-organization) and make sure they approve your request. | |||
| - **Request form**: Gather [all the information you’ll need](../../domains/before/#information-you’ll-need-to-complete-the-domain-request-form) to complete your domain request. | |||
| - **Senior official**: [Find out who your senior official is](../../domains/eligibility/#you-must-have-approval-from-an-senior-official-within-your-organization) and make sure they approve your request. | |||
There was a problem hiding this comment.
small nit: ...-a-senior-official-...
| - **Authorizing official**: [Find out who your authorizing official is](../../domains/eligibility/#you-must-have-approval-from-an-authorizing-official-within-your-organization) and make sure they approve your request. | ||
| - **Request form**: Gather [all the information you’ll need](../../domains/before/#information-you’ll-need-to-complete-the-domain-request-form) to complete your domain request. | ||
| - **Senior official**: [Find out who your senior official is](../../domains/eligibility/#you-must-have-approval-from-an-senior-official-within-your-organization) and make sure they approve your request. | ||
| - **Request form**: Gather [all the information you’ll need](../../domains/before/#information-you-will-need-to-complete-the-domain-request) to complete your domain request. |
pages/domains/domains_election.md
Outdated
| @@ -30,9 +30,9 @@ Using a .gov domain for your online services (like your website or email) helps | |||
|
|
|||
| ### An official from your organization needs to approve your domain request | |||
|
|
|||
| All domain requests must be approved by an authorizing official. This person must be in a role of significant, executive responsibility within the organization. | |||
| All domain requests must be approved by an senior official. This person must be in a role of significant, executive responsibility within the organization. | |||
There was a problem hiding this comment.
Suggested change
| All domain requests must be approved by an senior official. This person must be in a role of significant, executive responsibility within the organization. | |
| All domain requests must be approved by a senior official. This person must be in a role of significant, executive responsibility within the organization. |
There was a problem hiding this comment.
Updated! 
pages/domains/domains_eligibility.md
Outdated
| @@ -27,12 +27,12 @@ If you’re eligible to have a .gov domain, we want you to get one. The types of | |||
| After you request a .gov domain, we'll review the information you provided about your organization. We use the [U.S. Census Bureau’s criteria for classifying governments](https://www.census.gov/programs-surveys/gus/technical-documentation/methodology/population-of-interest1.html){.usa-link--external} to help determine eligibility. In some cases, we’ll ask for more information (such as legislation, a charter, or bylaws) to verify eligibility. | |||
|
|
|||
|
|
|||
| ## You must have approval from an authorizing official within your organization | |||
| Your authorizing official is a person within your organization who can authorize your domain request. This person must be in a role of significant, executive responsibility within the organization. | |||
| ## You must have approval from an senior official within your organization | |||
There was a problem hiding this comment.
This should be "a senior official" - not updating because I think that will break links in various places. Can you update here and in the links?
There was a problem hiding this comment.
Here are the new links to click through!
Before you request (this one has two links on this page for the senior official portion which should lead to the link below!)
The main link for approval from a senior official
Katherine-Osos
approved these changes
Jun 27, 2024
46 tasks
therealslimhsiehdy
assigned therealslimhsiehdy and erinysong and unassigned therealslimhsiehdy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #2259
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots