Merge pull request #152 from cisagov/bugfix/fix-broken-install-of-pyt…

…hon2-tool Fix broken installations of ImpDump and Visual Studio Code
cisagov · Aug 24, 2023 · 3af6a2e · 3af6a2e
2 parents 4676f2b + 1f3f3b1
commit 3af6a2e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/assessor_tools.yml b/src/assessor_tools.yml
@@ -272,7 +272,9 @@
         assessment_tool_archive_src: https://github.com/HarmJ0y/ImpDump/tarball/master
         assessment_tool_install_dir: /tools/ImpDump
         assessment_tool_pip_packages:
-          - impacket
+          # impacket>=0.11.0 has a dependency that only supports
+          # Python 3.
+          - impacket<0.11.0
           - pycrypto
         assessment_tool_python2: yes
         assessment_tool_python_install_development_dependencies: yes

diff --git a/src/requirements.yml b/src/requirements.yml
@@ -49,7 +49,12 @@ roles:
   - name: upgrade
     src: https://github.com/cisagov/ansible-role-upgrade
   - name: visual_studio_code
-    src: gantsign.visual-studio-code
+    # TODO: We can revert to gantsign.visual-studio-code (and remove
+    # the version entry) once
+    # gantsign/ansible-role-visual-studio-code#244 is merged.  See
+    # #153 for more information.  src: gantsign.visual-studio-code
+    src: https://github.com/1337-42/ansible-role-visual-studio-code
+    version: update-apt-dep
   - name: vnc_server
     src: https://github.com/cisagov/ansible-role-vnc-server
   - name: xfce_cool

diff --git a/src/version.txt b/src/version.txt
@@ -1 +1 @@
-__version__ = "0.5.20"
+__version__ = "0.5.21"