Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Kali base AMI #172

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 13, 2024

🗣 Description

This pull request modifies the Packer code to use the latest version of the Kali base AMI.

💭 Motivation and context

Using the latest Kali base AMI:

  • Puts us in a better place to integrate future versions of the Kali base AMI
  • Means fewer package upgrades in our upgrade Ansible provider

🧪 Testing

All automated tests pass. I built and tested a Kali staging AMI in our staging COOL and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

✅ Post-merge checklist

  • Create a release.

This will mean fewer packages to update in the upgrade Ansible
provider.
This is necessary because the community.general collection is listed
as a dependency in src/requirements.yml.
@jsf9k jsf9k added version bump This issue or pull request increments the version number packer Pull requests that update Packer code labels Sep 13, 2024
@jsf9k jsf9k self-assigned this Sep 13, 2024
@jsf9k
Copy link
Member Author

jsf9k commented Sep 16, 2024

The build failures are because of TheWover/donut#158. Once that PR is merged this one should build cleanly as well.

@jsf9k jsf9k mentioned this pull request Sep 18, 2024
The fork being used contains the changes from TheWover/donut#158,
which are necessary in order to build the tool.  Once that pull
request is merged we can revert this change.

See #173 for more details.
…nt-tool

This is being done for testing purposes and this change can be
reverted once cisagov/ansible-role-assessment-tool#59 has been merged.
FortyNorthSecurity has renamed itself RedSiege.
This is being done because RedSiege/EXCELntDonut has a dependency on
TheWover/donut, and we want to depend on jsf9k/donut instead until
TheWover/donut#158 is merged.
@jsf9k jsf9k force-pushed the improvement/use-latest-kali-base-ami branch from 396c582 to 87a543e Compare September 19, 2024 19:43
@jsf9k jsf9k added the ansible Pull requests that update Ansible code label Sep 19, 2024
lgandx/Responder np longer requires the readline Python package.  The
Python standard module readline is sufficient.  In any event, the
readline PyPI package has been renamed to gnureadline.
lgandx/Responder now requires this netifaces Python module.
@jsf9k jsf9k force-pushed the improvement/use-latest-kali-base-ami branch from 14be4c5 to eb7d6f1 Compare September 20, 2024 03:13
@jsf9k jsf9k marked this pull request as ready for review September 20, 2024 14:38
@jsf9k jsf9k requested a review from a team September 20, 2024 14:38
…-agent

We can do this now that cisagov/ansible-role-amazon-ssm-agent#59 has
been merged.
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit eb403c4 into develop Sep 20, 2024
8 checks passed
@jsf9k jsf9k deleted the improvement/use-latest-kali-base-ami branch September 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Pull requests that update Ansible code packer Pull requests that update Packer code version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants