Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster deployment #24

Merged
merged 4 commits into from
Oct 30, 2024
Merged

cluster deployment #24

merged 4 commits into from
Oct 30, 2024

Conversation

przsus
Copy link
Contributor

@przsus przsus commented Oct 22, 2024

Pull Request summary:

Setup cluster config when vManages contain cluster_private_ip var

Description of changes:

Complete cluster setup from scratch

Checklist:

  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@przsus przsus requested a review from cicharka October 22, 2024 11:33
@przsus przsus requested review from sashiv20 and cicharka October 24, 2024 09:49
cicharka
cicharka reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@cicharka cicharka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also add note in main README.md about cluster configuration. It should be emphasized that we are supporting cluster configuration

galaxy.yml Show resolved Hide resolved
playbooks/aws/aws_sdwan_config.yml Show resolved Hide resolved
@przsus przsus requested a review from cicharka October 30, 2024 08:03
@przsus przsus merged commit 9be4d3d into main Oct 30, 2024
5 checks passed
@przsus przsus deleted the fr/cluster branch October 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicharka cicharka cicharka approved these changes

@sashiv20 sashiv20 Awaiting requested review from sashiv20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przsus @sashiv20 @cicharka