Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Global Pool with ip_address_space is 'ipv4' or 'IPV4' fail #29

Merged

Conversation

Kandarimegha
Copy link

Description

In this commit:

  • Fix Create a Global Pool with ip_address_space is 'ipv4' or 'IPV4' fail

The Modified code normalizes the ip_address_space value from pool_details to ensure it follows a consistent format (IPv4). It retrieves the ip_address_space value, converts it to uppercase, and then checks if it matches "IPV4". If it does, the value is standardized to "IPv4". This approach allows for flexibility in input format (e.g., IPV4, ipv4, etc.).

Type of Change

  • [ Yes] Bug fix
  • [ No] New feature
  • [ No] Breaking change
  • [ No] Documentation update

Checklist

  • [ Yes] My code follows the style guidelines of this project
  • [ Yes] I have performed a self-review of my own code
  • [ Yes] I have commented my code, particularly in hard-to-understand areas
  • [ Yes] I have made corresponding changes to the documentation
  • [ Yes] My changes generate no new warnings
  • [ Yes] I have added tests that prove my fix is effective or that my feature works
  • [ Yes] New and existing unit tests pass locally with my changes
  • [ No] Any dependent changes have been merged and published in downstream modules
  • [ Yes] All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • [ Yes] Tasks are idempotent (can be run multiple times without changing state)
  • [ No] Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • [ Yes] Playbooks are modular and reusable
  • [ No] Handlers are used for actions that need to run on change

Documentation

  • [ Yes] All options and parameters are documented clearly.
  • [ Yes] Examples are provided and tested.
  • [ Yes] Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

Copy link
Collaborator

@madhansansel madhansansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity errors, can you fix it?

Copy link
Collaborator

@madhansansel madhansansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the Sanity errors?

@madhansansel madhansansel merged commit 251845f into cisco-en-programmability:main Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants