-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml document related changes code is working fine #41
Yaml document related changes code is working fine #41
Conversation
…talyst-center-ansible-intg into accesspoint_feature_enhancement_ut
@@ -263,7 +263,7 @@ | |||
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom". | |||
type: str | |||
required: False | |||
power_level: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change here or in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the code i have used powerlevel, hence the api response of AP config also same. i have fixed the code long back forget to change in this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If power_level is released to customer, then we can use power_level itself.
power_level is more consistent with YAML's preference for clarity and common conventions.
Why did you change power_level into powerlevel in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we merged first time we used the power_level QA bug was raised not working in power level. then we checked the code. while checking we found update ap config the payload was changed to powerLevel. actually in the payload as well as ap config response, both powerlevel only using. we are using function to convert snake case to camel case to create payload. there we are getting problem. those we fixed in the last bug with powerlevel. that i need to update in the yml document i missed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed the commnets.
@@ -263,7 +263,7 @@ | |||
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom". | |||
type: str | |||
required: False | |||
power_level: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the code i have used powerlevel, hence the api response of AP config also same. i have fixed the code long back forget to change in this document.
…talyst-center-ansible-intg into accesspoint_feature_enhancement_ut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change to power_level, the dynamic function used for snake_case to camel case will have problem. so we used powerlevel
@@ -263,7 +263,7 @@ | |||
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom". | |||
type: str | |||
required: False | |||
power_level: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we merged first time we used the power_level QA bug was raised not working in power level. then we checked the code. while checking we found update ap config the payload was changed to powerLevel. actually in the payload as well as ap config response, both powerlevel only using. we are using function to convert snake case to camel case to create payload. there we are getting problem. those we fixed in the last bug with powerlevel. that i need to update in the yml document i missed it
…talyst-center-ansible-intg into accesspoint_feature_enhancement_ut
687def1
into
cisco-en-programmability:main
Description
[CSCwm83940] - Updating Power Level via Ansible is unsuccessful
[CSCwm47563] - Update documentation to change secondary, tertiary controller names as mandatory field
Type of Change
Checklist
Ansible Best Practices
ansible-vault
or environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers