Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml document related changes code is working fine #41

Conversation

md-rafeek
Copy link
Collaborator

@md-rafeek md-rafeek commented Nov 25, 2024

Description

[CSCwm83940] - Updating Power Level via Ansible is unsuccessful
[CSCwm47563] - Update documentation to change secondary, tertiary controller names as mandatory field

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@@ -263,7 +263,7 @@
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom".
type: str
required: False
power_level:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change here or in the code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the code i have used powerlevel, hence the api response of AP config also same. i have fixed the code long back forget to change in this document.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If power_level is released to customer, then we can use power_level itself.
power_level is more consistent with YAML's preference for clarity and common conventions.

Why did you change power_level into powerlevel in the code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merged first time we used the power_level QA bug was raised not working in power level. then we checked the code. while checking we found update ap config the payload was changed to powerLevel. actually in the payload as well as ap config response, both powerlevel only using. we are using function to convert snake case to camel case to create payload. there we are getting problem. those we fixed in the last bug with powerlevel. that i need to update in the yml document i missed it

Copy link
Collaborator Author

@md-rafeek md-rafeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed the commnets.

@@ -263,7 +263,7 @@
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom".
type: str
required: False
power_level:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the code i have used powerlevel, hence the api response of AP config also same. i have fixed the code long back forget to change in this document.

Copy link
Collaborator Author

@md-rafeek md-rafeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we change to power_level, the dynamic function used for snake_case to camel case will have problem. so we used powerlevel

@@ -263,7 +263,7 @@
description: Mode of power assignment for the 2.4GHz radio interface. Accepts "Global" or "Custom". For example, "Custom".
type: str
required: False
power_level:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merged first time we used the power_level QA bug was raised not working in power level. then we checked the code. while checking we found update ap config the payload was changed to powerLevel. actually in the payload as well as ap config response, both powerlevel only using. we are using function to convert snake case to camel case to create payload. there we are getting problem. those we fixed in the last bug with powerlevel. that i need to update in the yml document i missed it

@madhansansel madhansansel merged commit 687def1 into cisco-en-programmability:main Dec 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants