swim bug fixed - image activation for all the child sites devices - V2.3.7.6 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| response = response.get('response') | ||
| site_names = site_name + ".*" | ||
| get_site_names = self.get_site(site_names) | ||
| self.log(get_site_names) |
There was a problem hiding this comment.
self.log("Fetched site names: {0}".format(str(get_site_names)), "DEBUG")
There was a problem hiding this comment.
fixed the code
| response = self.dnac._exec( | ||
| family="site_design", | ||
| function='get_site_assigned_network_devices', | ||
| op_modifies=True, |
There was a problem hiding this comment.
fixed the code
There was a problem hiding this comment.
have removed the op_modifies as it is not required for get
| params={"site_id": site_id}, | ||
| ) | ||
| self.log("Received API response from 'get_site_assigned_network_devices': {0}".format(str(response)), "DEBUG") | ||
| response = response.get('response') |
There was a problem hiding this comment.
instead:
devices = response.get('response')
if not devices:
self.log("No devices found for site - '{0}'.".format(site_name), "WARNING")
continue
There was a problem hiding this comment.
fixed the code
| except Exception as e: | ||
| self.log("Unable to fetch the device(s) associated to the site '{0}' due to '{1}'".format(site_name, str(e)), "WARNING") | ||
| return device_uuid_list | ||
| for device_id in response: |
There was a problem hiding this comment.
for device in devices:
device_id_list.append(device.get("deviceId"))
There was a problem hiding this comment.
fixed the code
| offset = offset + 1 | ||
| self.log("Received API response from 'device_list_response': {0}".format(str(device_list_response)), "DEBUG") | ||
| device_response = device_list_response.get('response') | ||
| self.log("Received API response: {0}".format(str(device_list_response)), "DEBUG") |
There was a problem hiding this comment.
self.log("Received API response from 'get_device_list': {0}".format(str(device_list_response)), "DEBUG")
There was a problem hiding this comment.
fixed the code
madhansansel
approved these changes
Dec 17, 2024
madhansansel
merged commit 8573416
into
cisco-en-programmability:main
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
image activation for all the child sites devices - V2.3.7.6
Type of Change
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers