Optimize _ pattern in syntax-case clauses #728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain
_
patterns insyntax-case
occurs fairly frequently in code (more than 80 occurrences in Chez Scheme itself), and these patterns never fail. There are used likeelse
clauses forsyntax-case
.An easy optimization is to avoid calling
$syntax-dispatch
for such patterns and directly embed the()
return value that would result for such a call. A similar optimization already existed for patterns that consists of a single identifier.With that optimization,
cp0
can easily optimize out the last call tosyntax-error
that is never reached.Before:
After:
Note: there is something fishy with the GitHub workflows, and one random job would fail. It happened on the main in my fork, as well as with my branch.