Expand comment on work-around

cisco · Dec 15, 2023 · b7cc914 · b7cc914
1 parent a3218a9
commit b7cc914
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/include/mls/common.h b/include/mls/common.h
@@ -84,7 +84,12 @@ struct overloaded : Ts...
 {
   using Ts::operator()...;
 
-  // TODO(RLB) explanatory comment
+  // XXX(RLB) MSVC has a bug where it incorrectly computes the size of this
+  // type.  Microsoft claims they have fixed it in the latest MSVC, and GitHub
+  // claims they are running a version with the fix.  But in practice, we still
+  // hit it.  Including this dummy variable is a work-around.
+  //
+  // https://developercommunity.visualstudio.com/t/runtime-stack-corruption-using-stdvisit/346200
   int dummy = 0;
 };