Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JWK utilities, VC, and MultiCredential #355

Merged
merged 20 commits into from
Aug 28, 2023
Merged

Implement JWK utilities, VC, and MultiCredential #355

merged 20 commits into from
Aug 28, 2023

Conversation

glhewett
Copy link
Contributor

@glhewett glhewett commented Jul 31, 2023

In order to integrate userinfo via verifiable certificates, updating the MLSpp library with a basic JWK import and export will allow the verification of keys to be a bit more straight forward. This pull requires does not verify any cross signing functionality.

  • Import JWK private key from MLS private key
  • Import JWK public key from MLS public key
  • Export JWK private key from MLS private key
  • Export JWL public key from MLS public key
  • Supports OpenSSL 1.1.1
  • Supports OpenSSL 3.0
  • New high level tests in test/crypto.cpp
  • Low level tests in lib/hpke/test/signature.cpp

@bifurcation bifurcation changed the title import and export jwk into signature keys. Implement JWK utilities, VC, and MultiCredential Aug 25, 2023
Copy link
Contributor

@suhasHere suhasHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, looking great overall.

include/mls/credential.h Show resolved Hide resolved
include/mls/credential.h Outdated Show resolved Hide resolved
lib/hpke/src/base64.cpp Show resolved Hide resolved
@glhewett glhewett merged commit f27e8b7 into main Aug 28, 2023
13 checks passed
@glhewett glhewett deleted the userinfo-vc branch August 28, 2023 19:35
@glhewett glhewett restored the userinfo-vc branch August 28, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants