-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run slow/expensive CI jobs if faster jobs fail #361
Conversation
1e4d353
to
1b39267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The names of the CI tasks are inconsistent. I would suggest:
- Capitalize the first word, lower case thereafter
- Use "OpenSSL 1.1" and "OpenSSL 3" consistently
jobs:
formatting-check:
name: Formatting check
quick-linux-interop-check:
needs: formatting-check
name: Quick Linux Check and Interop
runs-on: ubuntu-latest
- name: Dependencies (ubuntu)
- name: Restore cache
- name: Configure (OpenSSL 1.1)
- name: Build (OpenSSL 1.1)
- name: Test (OpenSSL 1.1)
- name: Build (Interop Harness)
- name: Test self-interop
- name: Test interop on test vectors
- name: Test gRPC live interop with self
- name: Configure (OpenSSL 3)
- name: Build (OpenSSL 3)
- name: Unit tests (OpenSSL 3)
platform-sanitizer-tests:
needs: quick-linux-interop-check
name: Build and test platforms using sanitizers and clang-tidy
steps:
- name: Dependencies (macos)
- name: Dependencies (ubuntu)
- name: Restore cache
- name: Configure (OpenSSL 1.1)
- name: Build (OpenSSL 1.1)
- name: Test (OpenSSL 1.1)
- name: Configure (OpenSSL 3)
- name: Build (OpenSSL 3)
- name: Test (OpenSSL 3)
Also it seems like we have Configure/Build/Test everywhere except for the interop harness, which only has Build/Test. Let's consolidate the Configure/Build steps into just Build. |
Great feedback. I had not taken the higher level view yet. I have responded to all of you feedback. |
12b9c32
to
e533d14
Compare
I am looking for a faster CI, and these were some obvious updates to make. Actually, I could not stop making changes. Here is a list of the changes in this PR.