Convert tests to Catch2 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out that what happens in CI is that the Windows tests still hang without I think it's still worthwhile to merge this PR, in order to get on a more supported testing framework. |
|
Did you meant to comment out all of the tests? I guess not: #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #415, doctest is broken and abandoned. Catch2 seems to be a more standard and more supported test framework. This PR converts MLSpp's tests from doctest to Catch2.
vcpkg.jsonfiles so that Catch2 is available in all configurationsAnd for good measure, I went ahead and re-enabled tests on Windows. We'll see what happens in CI!