fix(msgpack): JSON map conversion error-handling #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
invalid
tens0rfl0w
force-pushed
the
fix/msgpack-json-map-error-handling
branch
2 times, most recently
from
6899a4f
to
d9188fa
Compare
This fixes various unhandled exceptions when trying to convert a msgpack map object to a JSON object: - Out-ouf-bounds exception handling when key type is int - Duplicate key check (when converting from int->string) - Invalid type as key -> type ≠ string, int, bin
tens0rfl0w
force-pushed
the
fix/msgpack-json-map-error-handling
branch
from
d9188fa
to
e134121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Lua (unlike JS) does not convert table indices to String, which can result in table indices being of various types. Instead of throwing an unhandled exception, we now handle invalid-data more gracefully.
How is this PR achieving the goal
This change mimics the msgpack-c example impl. of map -> JSON conversion with added checks and verbose console errors.
Handling for the following cases has been added:
On error, the map object will get nullified to avoid partial data.
While not every case necessarily needs to throw an error, this was done to avoid 'wrong' user-data staying unnoticed.
Different key types (string, int) in the same map are also now supported.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: Not applicable
Platforms: Windows (Client)
Checklist
Fixes issues
/