Bind fastify to both ipv4 and ipv6 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Weissmann <christian.weissmann@s44.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running automated tests for the operator ui against real services, I ran into the issue that the test couldn't resolve to the citrine-core server. After some deeper digging it turned out that the server only was binding to ipv4 but the test was trying to find for ipv6.
Fastify mentions here: https://fastify.dev/docs/v4.28.x/Reference/Server/#listentextresolver that docker should bind to
0.0.0.0. But this is only binding to ipv4. So for local we now bind::which listens to everything on both v4 and v6.