-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Advanced UI #65
Conversation
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! There are some changes I'd like; see review comments.
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
Thanks a lot Thana! The feedback is very helpful! I updated the code. Pls let me know if there are any further comments. |
Signed-off-by: lydiazcheng <lydiazcheng@users.noreply.github.com>
Signed-off-by: Zihe Cheng <lydiazcheng@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR implements
Local tests
Use wscat to test display messages related as well as show specific tariff use cases. Use EVerest for other use cases.
Set Display Message
Get Display Message
[2, "e328fcbf-aa7d-4057-9117-e180b184a210", "NotifyDisplayMessages", {"requestId": 1, "messageInfo":[{"id":1,"priority":"AlwaysFront","endDateTime":"2024-04-01T00:00:00.000Z","startDateTime":"2024-03-28T19:08:08.519Z","message":{"format":"ASCII","content":"This is a test message."},"display":{"name":"MonitoringCtrlr"}},{"id":2,"priority":"NormalCycle","startDateTime":"2024-03-28T19:08:08.519Z","endDateTime":"2024-04-01T00:00:00.000Z","message":{"format":"ASCII","content":"This is a test message."},"display":{"name":"MonitoringCtrlr"}}]}]
Clear a Display Message
Show EV Driver Running Total Cost During Charging
Send CostUpdatedRequest every minute
Alternative scenario: update cost when receiving TransactionEventRequest (eventType=Updated)
after receiving the transaction event, citrine calculates by all meter values of this transaction and return the total cost in response.
Show EV Driver Final Total Cost After Charging
After stop the transaction (EVDisconnected), returns the final cost.
Show EV Driver-specific Tariff Information
charger send a authorize request and then citrine set the tariff info in the response if the id token is accepted. (To simplify the test, I change the code in the handler temporarily to force id token status always to be accepted.)
Update Tariff Information During Transaction
after receiving TransactionEventRequest (eventType = Updated) , citrine should check if there is updated tariff and send it back to charger. Since we don’t have such a case, I currently just print a log here.
Create/Find/Delete Tariff