Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: DeleteCertificates message and Installed Certificates CRUD #21

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

elliot-sabitov
Copy link

@elliot-sabitov elliot-sabitov commented Oct 19, 2024

Please Note: Related CORE PR citrineos/citrineos-core#284

  • feat: created Installed Certificates CRUD resource in app to track certificate hashes for installed certificates that are on the chargers
  • feat: because there are some issues with creation, for now enabled the primary field when creating a new record, because otherwise there was no way to create a charging station, also enabled edit in /evses/id/edit for now to try and step around the bugs a bit to make more functional progress, most bugs related to associations or editing not quite populating correctly and persisting in some cases.
  • feat: created initial DeleteCertificate message component and added it to charging station ui, and then also created a custom action to delete certificate that is also in the InstallCertificate table UI

Please Note: Because of issue with association selection, in some of the screenshots, you will see the selection doesnt show the value properly, but the component does have it in memory and the request does complete successfully!

  • Installing Certificate
    Screenshot 2024-10-18 at 11 29 52 PM
  • Installed Certificated table shows the newly installed certificate record
    Screenshot 2024-10-18 at 11 44 59 PM
  • Delete certificate selection on Charging Station table
    Screenshot 2024-10-18 at 11 31 06 PM
  • Delete certificate selection initial state before selection made
    Screenshot 2024-10-18 at 11 31 11 PM
  • Installed certificate selection made (Please note, selection empty in UI but Component has value in memory and request is made successfully)
    Screenshot 2024-10-18 at 11 31 26 PM
  • Install certificate response from Citrine
    Screenshot 2024-10-18 at 11 31 37 PM
  • Installed Certificates table also supporting DeleteCertificate message
    Screenshot 2024-10-18 at 11 30 14 PM
  • Installed Certificates table doesnt require any further input and just triggers the request and shows success
    Screenshot 2024-10-18 at 11 30 18 PM

Elliot Sabitov added 3 commits October 18, 2024 23:35
…rtificate hashes for installed certificates that are on the chargers

feat: because there are some issues with creation, for now enabled the primary field when creating a new record, because otherwise there was no way to create a charging station, also enabled edit in /evses/id/edit for now to try and step around the bugs a bit to make more functional progress, most bugs related to associations or editing not quite populating correctly and persisting in some cases.
feat: created initial DeleteCertificate message component and added it to charging station ui, and then also created a custom action to delete certificate that is also in the InstallCertificate table UI
…eature/delete-certificate

* feature/making-message-components-more-reusable:
  refactor: update reset to use generic form and correct EVSE selection.
  bugfix: fixing linting in trigger-message
  bugfix: removing unused imports
  bugfix: only including evse in trigger message if available as an argument + fixing response handling when sending trigger message request
  bugfix: fixing linting in trigger-message
  bugfix: removing unused imports
  bugfix: only including evse in trigger message if available as an argument + fixing response handling when sending trigger message request
…eature/delete-certificate

* feature/making-message-components-more-reusable:
  chore: resolving build and lint issues
@thanaParis thanaParis changed the base branch from feature/making-message-components-more-reusable to rc-0.2.0 October 23, 2024 20:05
@thanaParis thanaParis marked this pull request as ready for review October 23, 2024 20:05
@thanaParis thanaParis self-requested a review October 23, 2024 20:07
Copy link
Contributor

@thanaParis thanaParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@thanaParis thanaParis merged commit 5390c0d into rc-0.2.0 Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants