CircleCI to GHA migration #7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanefi
reviewed
Oct 9, 2023
| @@ -698,7 +698,6 @@ jobs: | |||
| workflows: | |||
| version: 2 | |||
| flaky_test_debugging: | |||
| when: << pipeline.parameters.flaky_test >> | |||
There was a problem hiding this comment.
I guess we want to revert the changes to this file before merge, right?
| @@ -0,0 +1,38 @@ | |||
| name: save_logs_and_results | |||
There was a problem hiding this comment.
Why do we not have a human-readable name instead?
Suggested change
| name: save_logs_and_results | |
| name: Save logs and results |
I assumed quotation marks are not necessary, but I am not so sure about that.
| @@ -0,0 +1,35 @@ | |||
| name: setup_extension | |||
There was a problem hiding this comment.
Why do we not have a human-readable name here?
| - ${{ vars.pg14_version }} | ||
| - ${{ vars.pg15_version }} | ||
| - ${{ vars.pg16_version }} | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
I would have preferred if we have migrated to 22.04. Feel free to ignore if this is too much work.
| test-flakyness: | ||
| if: ${{ needs.test-flakyness-pre.outputs.tests != ''}} | ||
| name: Test flakyness | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Do you think that it makes sense to store all the runs-on values in a variable so that it is easier to update in the future?
hanefi
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
I am approving this PR as we want to start running tests on GHA. I expect @gokhangulbiz to address the comments on my earlier review after he is back to work.
gokhangulbiz
added a commit
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
gokhangulbiz
added a commit
that referenced
this pull request
Nov 2, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: