Fix system_queries test to actually test the problem

[Green-Chan]

The test added in #7604 doesn't reach the HasRangeTableRef function and thus doesn't test what it should.

[JelteF]

Could you change the base for this PR to the main? We normally merge everything into main and then cherry-pick to the release branches, but we didn't follow that approach by accident for #7604

[gurkanindibay]

Thanks @Green-Chan for the fix.

[Green-Chan]

I've rebased the branch to updated main.
Check if all GUCs are sorted alphabetically has failed, and I can't see how since shared_library_init.c isn't even changing in this PR.
Could someone please help me?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (3c467e6) to head (1db28fa).

❗ There is a different number of reports uploaded between BASE (3c467e6) and HEAD (1db28fa). Click for more details.

HEAD has 75 uploads less than BASE

Flag	BASE (3c467e6)	HEAD (1db28fa)
16_regress_check-pytest	1	0
15_regress_check-pytest	1	0
15_regress_check-follower-cluster	1	0
16_regress_check-query-generator	1	0
14_regress_check-enterprise-failure	1	0
14_16_upgrade	1	0
14_15_upgrade	1	0
15_16_upgrade	1	0
15_regress_check-columnar-isolation	1	0
16_regress_check-split	1	0
16_regress_check-enterprise-failure	1	0
16_regress_check-enterprise-isolation-logicalrep-2	1	0
14_regress_check-enterprise-isolation-logicalrep-1	1	0
14_regress_check-enterprise-isolation	1	0
15_regress_check-enterprise-isolation-logicalrep-1	1	0
15_regress_check-columnar	1	0
15_regress_check-enterprise-failure	1	0
15_regress_check-operations	1	0
16_regress_check-enterprise-isolation-logicalrep-1	1	0
16_regress_check-vanilla	1	0
15_regress_check-multi-mx	1	0
16_regress_check-failure	1	0
16_regress_check-enterprise-isolation	1	0
15_regress_check-failure	1	0
14_regress_check-multi-mx	1	0
_upgrade	17	3
14_regress_check-vanilla	1	0
16_regress_check-enterprise	1	0
15_regress_check-enterprise	1	0
15_regress_check-query-generator	1	0
15_regress_check-vanilla	1	0
14_regress_check-split	1	0
14_regress_check-enterprise	1	0
14_regress_check-operations	1	0
16_regress_check-multi-1	1	0
15_regress_check-multi-1	1	0
14_regress_check-multi-1	1	0
16_regress_check-operations	1	0
15_regress_check-enterprise-isolation	1	0
14_regress_check-query-generator	1	0
14_regress_check-columnar-isolation	1	0
14_regress_check-follower-cluster	1	0
15_regress_check-enterprise-isolation-logicalrep-3	1	0
14_regress_check-enterprise-isolation-logicalrep-3	1	0
16_regress_check-enterprise-isolation-logicalrep-3	1	0
14_regress_check-columnar	1	0
14_regress_check-enterprise-isolation-logicalrep-2	1	0
15_regress_check-enterprise-isolation-logicalrep-2	1	0
16_regress_check-columnar	1	0
15_regress_check-split	1	0
15_regress_check-multi	1	0
14_regress_check-isolation	1	0
15_regress_check-isolation	1	0
14_regress_check-failure	1	0
16_cdc_installcheck	1	0
15_cdc_installcheck	1	0
16_regress_check-multi-mx	1	0
16_regress_check-isolation	1	0
14_regress_check-multi	1	0
16_regress_check-columnar-isolation	1	0
14_regress_check-pytest	1	0
16_regress_check-follower-cluster	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7613       +/-   ##
===========================================
- Coverage   89.70%   73.34%   -16.37%     
===========================================
  Files         283      283               
  Lines       60506    60063      -443     
  Branches     7539     7454       -85     
===========================================
- Hits        54276    44051    -10225     
- Misses       4073    13162     +9089     
- Partials     2157     2850      +693     

[Green-Chan]

Finally all required tests have passed!
@JelteF could you please merge it?
I would also love some advice for the future how to deal with randomly failing required tests. I can't rerun them other than by pushing something new to the branch, but pushing disables auto-merge.