Remove or replace unconventional repositories #185
Conversation
How the hell did I not notice that? Gradle cache never ceases to annoy me
|
I don't know why CI fails now however and since I don't want to play games with it I'll just close this PR |
|
Haha I've been fighting Vault specifically since the beginning, I think I've used 2-3 different repos over the years trying to get it to find it. I think it's on the developer's end, something else that used to happen was that releases I depended on would go missing entirely and fail to build. I'm not sure what causes it but it used to drive me insane lol |
|
Right now a dependency of Worldedit makes the build fail though, so idk what happened there |
|
Crap that's it, not Vault. I had to try two different repos when I added Vault and then had to update to a different one, but WorldGuard and WorldEdit break a couple times a year it feels like. I'm not sure why, but I know it isn't always the repo because just visiting it in the browser lets me download it raw. Idk how many times I've fiddled with the repo but I did a dep cleanup a year ago or so I think, and it had been mostly working until recently, then it started working again?? |
|
The enginehub repository usually should work (as it basically is the sk89q repo but not mirrored), which is why I'm also a bit confused. I also had no issues using this plugin as a depend in one of my maven projects (but to be fair, I always exclude all dependencies of the dependencies). You are free to reopen and merge this PR, but given that CI fails (or at least failed once) I closed it as there might be a reason why the repos were like that. |
|
I can fiddle around later and see if I'm able to get it working |
As of MilkBowl/VaultAPI#90, the main repository of the VaultAPI is jitpack and as according to the Worldguard documentation eniginehub is the correct repository. Sonatype is only really needed for bungee, however it is already defined by MavenCentral so it will be obtained from there either way (since mavenCentral is defined above the sonatype repo) and I have no clue why papermc or mikeprimm's repositories are used.
I have tested that this compiles with a cleared gradle cache beforehand (and appearantly I didn't clear all caches and just a few, fun).