More names for Cuman, Norman, English culture #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily sourced from https://tekeli.li/onomastikon/England-Medieval/Norman.html
Github decided to encode it in UTF-8 for some reason, had to fix that
schwarherz
requested changes
Jul 28, 2024
| @@ -165,4 +165,77 @@ latin = { | |||
| mat_grm_name_chance = 60 | |||
| mother_name_chance = 10 | |||
| } | |||
|
|
|||
| norman = { | |||
There was a problem hiding this comment.
Norman should not be in the Latin group. It belongs in either gallo_roman (where it is currently) or north_germanic
There was a problem hiding this comment.
I have added the new names to the Gallo-Roman group, and undone my commits to the Latin group.
French cultures have been moved to the new Gallo-Roman group
French cultures have been moved to the new Gallo-Roman group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norman and English names sourced from Onomastikon (https://tekeli.li/onomastikon/England-Medieval/index.html), "Feminine Given Names in A Dictionary of English Surnames" (https://forum.paradoxplaza.com/forum/threads/new-cultures.610605/page-23#post-14655601)
Cuman names from PDX Forums: BloodMerchant and CrackdToothGrin (also provided new patronymics), https://forum.paradoxplaza.com/forum/threads/new-cultures.610605/