convert event model to be more like "The Elm Architecture" #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to make Russ's internal event model easier to understand, to enable easier understanding and contributions from other contributors (i.e., not me) by converting Russ's internal event model to be more like a curtailed version of The Elm Architecture ("TEA" for short).
The idea is not to copy TEA entirely (as the view code remains mostly unchanged) but to make the message/event handling easier to untangle.
There is more that we could possibly do here, to maybe introduce a notion of a Command, that performs and side effects like HTTP requests, database interactions, UI draw, etc., but that would be a much bigger change and I'd like to try this change first before moving forward with anything more ambitious.
This is also just a medium-sized refactoring, with some functionality moved around to hopefully make it clearer.