Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGOV changes #81

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

QGOV changes #81

wants to merge 12 commits into from

Conversation

ThrawnCA
Copy link
Contributor

@ThrawnCA ThrawnCA commented May 26, 2021

  • Make compatible with Python 3
  • Use UTC timestamps internally so we don't have conversion problems
  • Delete obsolete archives
  • Don't create archival tasks for changes to uploaded files (they get false positives and they don't need to be archived anyway since they're already stored in CKAN)
  • Integrate with additional Uploader APIs for downloads and metadata if available (see QGOV CKAN fork for details) to enable integration with alternative storage providers such as ckanext-s3filestore
  • Add Flake8 config
  • Add Github Actions workflow
  • Add more tests
  • Move requirements from setup.py to requirements files

@Zharktas
Copy link
Member

Let's remove travis configuration completely, it's not really usable anymore. I'll try to review this soonish.

@Zharktas
Copy link
Member

I'll add github action workflow as a separate PR today, so that the action is run for this PR too.

@ThrawnCA
Copy link
Contributor Author

@Zharktas What was wrong with the Github Workflow in this pull request?

@Zharktas
Copy link
Member

The only thing wrong with it, is that it's not run as you have no permissions for this repository. Now that there is a existing workflow, the pull requests will trigger the workflow. And i would like python3 support as separate pull request as python3 support itself does nothing unless CKAN 2.9 is supported as well. There is mine #73, which might do the rest of it once I have time to finish it.

@ThrawnCA
Copy link
Contributor Author

Well, this is just a merge of all changes in our fork except build config specific to our repos. If you want to split it, feel free.

I've merged master to resolve the conflicts, though.

@Zharktas
Copy link
Member

I approved running github action, as it is required for the first time. I'm all in for improving archiver itself, it just might take awhile to get it merged :)

pthiemt added a commit to GeoinformationSystems/ckanext-archiver that referenced this pull request Jun 22, 2021
@ThrawnCA ThrawnCA force-pushed the qgov-changes branch 2 times, most recently from e1fb38d to 98a8166 Compare September 16, 2022 01:35
- Only run on pull request if targeting master, since 'push' covers most cases except for cross-repo pull requests.


- This script calls either 'paster' or 'ckan' according to what is available, adjusting parameters as needed
- Also combine duplicate exception blocks
- This allows us to easily apply null-checks to every lookup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants