Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in insertImage command, tooltip manager and mention #17177

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Dumluregn
Copy link
Contributor

@Dumluregn Dumluregn commented Sep 27, 2024

Suggested merge commit message (convention)

Feature (image): Added a possibility to break the current block by InsertImageCommand with breakBlock flag. Closes #17742.

Feature (ui): The .ck-with-instant-tooltip class can now be used to display the tooltip without the delay. Closes #17743.

Feature (mention): Allow the mention marker to be longer than 1 character. Closes #17744.

Fix (ui): Tooltip will no longer show after quickly hovering and moving the mouse away before the tooltip shows. Closes
#16949.

Fix (ui): Tooltip will no longer disappear if cursor is moved back over the element with visible tooltip. Closes #17256.

Feature (clipboard): Pass information to the downcast converter when clipboard pipeline is used to allow for customization. Closes #17745.

Feature (clipboard): viewToPlainText() helper will now parse the view RawElement instances. Closes #17746.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@Dumluregn Dumluregn requested a review from scofalik September 27, 2024 14:43
scofalik
scofalik previously approved these changes Sep 30, 2024
@Dumluregn Dumluregn force-pushed the cc/image-merge-fields branch from 22278a5 to c87e63b Compare October 11, 2024 19:14
@Dumluregn Dumluregn changed the title Add possibility to break the current block by InsertImageCommand Improvements in insertImage command and tooltip manager Oct 11, 2024
@Dumluregn
Copy link
Contributor Author

Besides the previous insertImage command extension, now this PR also contains a few improvements related to tooltip manager (see the main PR comment).

@Dumluregn Dumluregn requested a review from scofalik October 11, 2024 20:17
scofalik
scofalik previously approved these changes Oct 16, 2024
Copy link
Contributor

@scofalik scofalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but as mentioned in merge fields PR, I'd consider having the "instant" tooltip also close "instantly".

@Dumluregn Dumluregn changed the title Improvements in insertImage command and tooltip manager Improvements in insertImage command, tooltip manager and mention Nov 4, 2024
@pomek
Copy link
Member

pomek commented Nov 4, 2024

Please use double empty lines as separators for changelog entries.

Entry 1.

Entry 2.

Copy link
Contributor

@scofalik scofalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

packages/ckeditor5-image/src/image/imageblockediting.ts Outdated Show resolved Hide resolved
packages/ckeditor5-clipboard/src/clipboardpipeline.ts Outdated Show resolved Hide resolved
@Dumluregn Dumluregn force-pushed the cc/image-merge-fields branch from 14d34aa to e4f326f Compare January 10, 2025 15:50
@scofalik scofalik merged commit 06cf625 into master Jan 10, 2025
10 checks passed
@scofalik scofalik deleted the cc/image-merge-fields branch January 10, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment