Feature digest improvements #17512
Merged
Feature digest improvements #17512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the things pointed out during the TP. I also added some CSS styles to the borders. Now, they group features and subfeatures. The groups are more visible, but does it look better? I dunno. You can check for yourself. |
gorzelinski
commented
Nov 21, 2024
There was a problem hiding this comment.
Unfortunately, this empty file is necessary.
pszczesniak
reviewed
Nov 21, 2024
There was a problem hiding this comment.
I'm not convinced how those rows = features + sub-features are colored. Maybe we could colored them alternately: feature with all sub-features with one colour, next with other and so on.
Pasting example to show you what is on my mind - but it would be good to discuss it, WDYT?
pszczesniak
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Docs: Feature digest improvements.
Additional information
Closes: #17495