add validation at MainOptions

clagomess · Mar 7, 2024 · 89df440 · 89df440
1 parent 9033686
commit 89df440
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/cli/src/main/java/com/github/clagomess/pirilampo/cli/MainOptions.java b/cli/src/main/java/com/github/clagomess/pirilampo/cli/MainOptions.java
@@ -5,11 +5,14 @@
 import com.github.clagomess.pirilampo.core.enums.CompilationTypeEnum;
 import com.github.clagomess.pirilampo.core.enums.HtmlPanelToggleEnum;
 import com.github.clagomess.pirilampo.core.enums.LayoutPdfEnum;
+import com.github.clagomess.pirilampo.core.exception.ParametersException;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.cli.*;
 
 import java.io.File;
 import java.util.Arrays;
 
+@Slf4j
 public class MainOptions {
     private final ParametersDto defaultParameters = new ParametersDto();
 
@@ -177,12 +180,18 @@ public ParametersDto getArgs(String[] argv){
                 parameters.setProjectTarget(new File(cmd.getOptionValue(projectTarget)));
             }
 
+            parameters.validate();
+
             return parameters;
-        } catch (ParseException e) {
-            System.out.println(e.getMessage());
+        } catch (ParseException | ParametersException e ) {
+            log.error(e.getMessage());
+        } catch (Throwable e) {
+            log.error(log.getName(), e);
+        } finally {
             new HelpFormatter().printHelp("Pirilampo", options);
-            System.exit(1);
-            return null;
         }
+
+        System.exit(1);
+        return null;
     }
 }
diff --git a/cli/src/test/java/com/github/clagomess/pirilampo/cli/MainOptionsTest.java b/cli/src/test/java/com/github/clagomess/pirilampo/cli/MainOptionsTest.java
@@ -13,4 +13,10 @@ public class MainOptionsTest {
     public void getArgs(){
         mainOptions.getArgs(new String[]{"-projectLogo", "aaa"});
     }
+
+    @Test
+    @ExpectSystemExitWithStatus(1)
+    public void getArgs_trigger_validate(){
+        mainOptions.getArgs(new String[]{"-projectSource", "aaa"});
+    }
 }