fix: campaign status with error where does not has phone number

clairton · Sep 18, 2024 · 01ac5a5 · 01ac5a5
1 parent cf6ce32
commit 01ac5a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/app/javascript/dashboard/routes/dashboard/settings/campaigns/CampaignCard.vue b/app/javascript/dashboard/routes/dashboard/settings/campaigns/CampaignCard.vue
@@ -134,6 +134,13 @@ export default {
       >
         {{ campaignReport }}
       </div>
+      <div
+        v-if="campaign.inbox.channel_type == 'Channel::Whatsapp'"
+        class="mb-1 text-xs text-slate-700 dark:text-slate-500"
+      >
+        {{ campaign.audience .filter(a => a.status == 'error') .map(a =>
+        `${a.name} : ${a.phone_number} <br />`) }}
+      </div>
     </div>
   </div>
 </template>
diff --git a/app/services/whatsapp/oneoff_unoapi_campaign_service.rb b/app/services/whatsapp/oneoff_unoapi_campaign_service.rb
@@ -21,7 +21,7 @@ def process_audience(audience)
     interval = 0
     new_audience = audience.map do |a|
       aa = update_audience(a)
-      interval = schedule_job(campaign, aa, interval)
+      interval = schedule_job(campaign, aa, interval) if aa[:status] == :scheduled
       aa
     end
     # rubocop:disable Rails/SkipsModelValidations
@@ -30,7 +30,7 @@ def process_audience(audience)
   end
 
   def update_audience(audience)
-    audience[:status] = :scheduled
+    audience[:status] = audience[:phone_number].present? ? :scheduled : :error
     audience[:audience_id] = SecureRandom.uuid
     audience.symbolize_keys
   end