Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function call #669

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Aug 6, 2024

No description provided.

@HighCommander4
Copy link
Contributor

For context: prior to db14900, this function call had the possible side effect of showing the user a prompt, and we were calling it for this side effect.

Since that commit that side effect no longer exists, and the function call seems to be unnecessary.

@HighCommander4 HighCommander4 merged commit e5b0022 into clangd:master Aug 6, 2024
1 check passed
@tamird tamird deleted the remove-no-op branch August 6, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants