FIX: extension activate failed if there is a space in clangd path #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding and fixing! |
HighCommander4
requested changes
Nov 5, 2024
HighCommander4
approved these changes
Nov 6, 2024
HighCommander4
added a commit
to HighCommander4/vscode-clangd
that referenced
this pull request
Nov 13, 2024
This reverts commit 4f64ca7.
HighCommander4
added a commit
that referenced
this pull request
Nov 13, 2024
JVApen
pushed a commit
to JVApen/vscode-clangd
that referenced
this pull request
Nov 18, 2024
)" This reverts commit 0cda54a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change
0c2d40d7d6b8092309bd2c880a32e59c71472a80addshell: trueto clangd options, which cause the extension activate failed if there is a space in clangd's path.Especially on windows, clangd installed under 'C:\Program Files'