Add minimal API for language switching #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
requested review from
jhonatangcavalcanti,
joaopaulovieira and
towerz
joaopaulovieira
approved these changes
May 5, 2020
leandromoreira
requested changes
May 5, 2020
There was a problem hiding this comment.
Thanks a lot for the contribution but I'd like you to discard the dist changes. What do you think @joaopaulovieira ? or do we regenerate ?
|
Sure! It's better to not add changes to the dist folder. |
iSchluff
force-pushed
the
implement-language-api
branch
from
6cdca65 to
6dcb68c
Compare
|
Ok, I removed the dist changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is practically a small part of the changes in #43 (comment)
These are the only changes required to do proper language switching via a selector plugin so please consider it.