fix cache control

clashperk · Jun 18, 2024 · 099c14f · 099c14f
1 parent ca59e8f
commit 099c14f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/apps/service-auth/src/clans/clans.controller.ts b/apps/service-auth/src/clans/clans.controller.ts
@@ -1,6 +1,6 @@
 import { CurrentUser, JwtAuthGuard, RolesGuard } from '@app/auth';
 import { Public } from '@app/auth/decorators';
-import { Controller, Get, Param, Query, Res, UseGuards } from '@nestjs/common';
+import { Controller, Get, Header, Param, Query, Res, UseGuards } from '@nestjs/common';
 import { ApiBearerAuth, ApiResponse, ApiTags } from '@nestjs/swagger';
 import { Response } from 'express';
 import { ClansService } from './clans.service';
@@ -43,13 +43,10 @@ export class ClansController {
 
  @Public()
  @Get('/:clanTag/badges/:size')
+ @Header('Cache-Control', 'max-age=600')
  @ApiResponse({ type: CWLStatsOutput, status: 200 })
- async getClanBadges(
- @Param('clanTag') clanTag: string,
- @Param('size') size: string,
- @Res() res: Response,
- ) {
- const buffer = await this.clansService.getClanBadges(clanTag, size);
+ async getClanBadges(@Param('clanTag') clanTag: string, @Res() res: Response) {
+ const buffer = await this.clansService.getClanBadges(clanTag);
  res.setHeader('Content-Type', 'image/png');
  return res.send(Buffer.from(buffer));
  }

diff --git a/apps/service-auth/src/clans/clans.service.ts b/apps/service-auth/src/clans/clans.service.ts
@@ -345,8 +345,8 @@ export class ClansService {
  return 'lost';
  }
 
- public async getClanBadges(clanTag: string, size: string) {
+ public async getClanBadges(clanTag: string) {
  const clan = await this.clashClientService.getClanOrThrow(clanTag);
- return fetch(clan.badgeUrls[size]).then((res) => res.arrayBuffer());
+ return fetch(clan.badgeUrls.large).then((res) => res.arrayBuffer());
  }
 }