Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dav URL for cases where user ID does not match username #24

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

claucambra
Copy link
Owner

Should fix more LDAP issues

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra self-assigned this Nov 4, 2024
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.27027% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.55%. Comparing base (bb36e8e) to head (eba9666).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
Sources/NextcloudFileProviderKit/Item/Item.swift 0.00% 17 Missing ⚠️
...s/NextcloudFileProviderKitTests/AccountTests.swift 0.00% 4 Missing ⚠️
...s/NextcloudFileProviderKit/Utilities/Account.swift 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   76.49%   76.55%   +0.06%     
==========================================
  Files          38       38              
  Lines        8136     8174      +38     
==========================================
+ Hits         6224     6258      +34     
- Misses       1912     1916       +4     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claucambra claucambra merged commit 6bc6961 into main Nov 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants